netdev - Re: [PATCH net-next v4 12/20] net: axienet: Add optional support for Ethernet core interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190606.140612.1821230680053274185.davem@davemloft.net>
Date:   Thu, 06 Jun 2019 14:06:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hancock@...systems.ca
Cc:     netdev@...r.kernel.org, anirudh@...inx.com, John.Linn@...inx.com,
        andrew@...n.ch
Subject: Re: [PATCH net-next v4 12/20] net: axienet: Add optional support
 for Ethernet core interrupt

From: Robert Hancock <hancock@...systems.ca>
Date: Wed,  5 Jun 2019 14:42:25 -0600

> +static irqreturn_t axienet_eth_irq(int irq, void *_ndev)
> +{
> +	unsigned int pending;
> +	struct net_device *ndev = _ndev;
> +	struct axienet_local *lp = netdev_priv(ndev);

Reverse christmas tree please.

If I didn't know better I'd say you were shooting for the exact
opposite ordering :-)