netdev - Re: [PATCH v4 bpf-next 0/2] bpf: Add a new API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b7c8e00-a0d5-7d45-017d-a8869cd8025c@iogearbox.net>
Date:   Sat, 8 Jun 2019 01:47:28 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Roman Gushchin <guro@...com>, Hechao Li <hechaol@...com>
Cc:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "ast@...nel.org" <ast@...nel.org>, Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v4 bpf-next 0/2] bpf: Add a new API

On 06/08/2019 01:25 AM, Roman Gushchin wrote:
> On 06/07/2019 06:37 PM, Hechao Li wrote:
>> Getting number of possible CPUs is commonly used for per-CPU BPF maps
>> and perf_event_maps. Add a new API libbpf_num_possible_cpus() that
>> helps user with per-CPU related operations and remove duplicate
>> implementations in bpftool and selftests.
>>
>> v4: Fixed error code when reading 0 bytes from possible CPU file
>>
>> Hechao Li (2):
>>   bpf: add a new API libbpf_num_possible_cpus()
>>   bpf: use libbpf_num_possible_cpus in bpftool and selftests
>>
>>  tools/bpf/bpftool/common.c             | 53 +++---------------------
>>  tools/lib/bpf/libbpf.c                 | 57 ++++++++++++++++++++++++++
>>  tools/lib/bpf/libbpf.h                 | 16 ++++++++
>>  tools/lib/bpf/libbpf.map               |  1 +
>>  tools/testing/selftests/bpf/bpf_util.h | 37 +++--------------
>>  5 files changed, 84 insertions(+), 80 deletions(-)
> 
>> Series applied, thanks!
> 
>> P.s.: Please retain full history (v1->v2->v3->v4) in cover letter next time as
>> that is typical convention and helps readers of git log to follow what has been
>> changed over time.
> 
> 
> Hello!
> 
> I'm getting the following errors on an attempt to build bpf tests.
> Reverting the last patch fixes it.
> 
[...]
> 
> clang -I. -I./include/uapi -I../../../include/uapi -idirafter /usr/local/include -idirafter /opt/fb/devtoolset/bin/../lib/clang/4.0.0/include -idirafter /usr/include -Wno-compare-distinct-pointer-types \
> 	 -O2 -target bpf -emit-llvm -c progs/sockmap_parse_prog.c -o - |      \
> llc -march=bpf -mcpu=generic  -filetype=obj -o /data/users/guro/linux/tools/testing/selftests/bpf/sockmap_parse_prog.o
> In file included from progs/sockmap_parse_prog.c:3:
> ./bpf_util.h:9:10: fatal error: 'libbpf.h' file not found
> #include <libbpf.h>
>          ^~~~~~~~~~
> 1 error generated.

True, I've therefore tossed the series from bpf-next. Hechao, please fix and resubmit.