netdev - Re: [PATCH bpf] bpf: lpm_trie: check left child of root for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F0ADF03F-A512-4E44-A1C7-A3877B255FE3@gmail.com>
Date:   Sat, 08 Jun 2019 08:21:35 -0700
From:   "Jonathan Lemon" <jonathan.lemon@...il.com>
To:     yhs@...com, ast@...nel.org, daniel@...earbox.net
Cc:     kernel-team@...com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf] bpf: lpm_trie: check left child of root for NULL

On 7 Jun 2019, at 19:44, Jonathan Lemon wrote:

> If the root of the tree has does not have any elements on the left
> branch, then trie_get_next_key (and bpftool map dump) will not look
> at the rightmost branch.  This leads to the traversal missing elements.

I just realized this doesn't handle all cases.  Will reroll a new version.
-- 
Jonathan  (sigh, #fridaynightfollies)