netdev - Re: [PATCH v3 net-next 09/20] ipv6: Handle all fib6_nh in a nexthop in rt6_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89620ba8-971a-f6a5-e1cf-20dc8eac1eca@gmail.com>
Date:   Fri, 7 Jun 2019 18:22:11 -0600
From:   David Ahern <dsahern@...il.com>
To:     Wei Wang <weiwan@...gle.com>, David Ahern <dsahern@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        idosch@...lanox.com, Martin KaFai Lau <kafai@...com>,
        Stefano Brivio <sbrivio@...hat.com>
Subject: Re: [PATCH v3 net-next 09/20] ipv6: Handle all fib6_nh in a nexthop
 in rt6_do_redirect

On 6/7/19 6:11 PM, Wei Wang wrote:
> I don't think you can directly return here. We are still holding
> rcu_read_lock() here. Probably need "goto out"...

ouch. yes, thank you for catching that.