netdev - Re: [PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190610.090602.2001139990603847705.davem@davemloft.net>
Date:   Mon, 10 Jun 2019 09:06:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jian.w.wen@...cle.com
Cc:     netdev@...r.kernel.org, john.r.fastabend@...el.com
Subject: Re: [PATCH net] net_sched: sch_mqprio: handle return value of
 mqprio_queue_get

From: David Miller <davem@...emloft.net>
Date: Mon, 10 Jun 2019 09:05:26 -0700 (PDT)

> From: Jacob Wen <jian.w.wen@...cle.com>
> Date: Mon, 10 Jun 2019 14:38:21 +0800
> 
>> It may return NULL thus we can't ignore it.
> 
> Please repost with a proper signoff.

Also, you are breaking the reverse christmas tree ordering of the local
variables with your change.  Please do not do that.