netdev - Re: [PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXk_-4zKJXkEDVUKUYxEpa8QNa8u2iD4BVxTTWQe=J4cA@mail.gmail.com>
Date:   Mon, 10 Jun 2019 11:19:54 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Jacob Wen <jian.w.wen@...cle.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        John Fastabend <john.r.fastabend@...el.com>
Subject: Re: [PATCH net] net_sched: sch_mqprio: handle return value of mqprio_queue_get

On Sun, Jun 9, 2019 at 11:41 PM Jacob Wen <jian.w.wen@...cle.com> wrote:
>
> It may return NULL thus we can't ignore it.

How is this possible? All of the callers should have validated
the 'cl' before calling this, for example by calling ->find().

I don't see it is possible to be NULL at this point.

Did you see a real crash? If so, please put the full stack trace
in your changelog.

Thanks!