netdev - Re: [PATCH V2 net-next 4/6] net: ena: allow queue allocation backoff when low on memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190610.093830.1398717949744756291.davem@davemloft.net>
Date:   Mon, 10 Jun 2019 09:38:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     sameehj@...zon.com, netdev@...r.kernel.org, dwmw@...zon.com,
        zorik@...zon.com, matua@...zon.com, saeedb@...zon.com,
        msw@...zon.com, aliguori@...zon.com, nafea@...zon.com,
        gtzalik@...zon.com, netanel@...zon.com, alisaidi@...zon.com,
        benh@...zon.com, akiyano@...zon.com
Subject: Re: [PATCH V2 net-next 4/6] net: ena: allow queue allocation
 backoff when low on memory

From: Andrew Lunn <andrew@...n.ch>
Date: Mon, 10 Jun 2019 18:36:59 +0200

> On Mon, Jun 10, 2019 at 09:18:40AM -0700, David Miller wrote:
>> From: <sameehj@...zon.com>
>> Date: Mon, 10 Jun 2019 14:19:16 +0300
>> 
>> > +static inline void set_io_rings_size(struct ena_adapter *adapter,
>> > +				     int new_tx_size, int new_rx_size)
>> 
>> Please do not ever use inline in foo.c files, let the compiler decide.
> 
> Hi David
> 
> It looks like a few got passed review:

I know :-/