netdev - Re: [PATCH net-next] tcp: Make tcp_fastopen_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33682081-78aa-a332-52c6-b1b6087e60dc@akamai.com>
Date:   Mon, 10 Jun 2019 12:43:50 -0400
From:   Jason Baron <jbaron@...mai.com>
To:     YueHaibing <yuehaibing@...wei.com>, edumazet@...gle.com,
        davem@...emloft.net, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: Make tcp_fastopen_alloc_ctx static

On 6/10/19 11:19 AM, YueHaibing wrote:
> Fix sparse warning:
> 
> net/ipv4/tcp_fastopen.c:75:29: warning:
>  symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  net/ipv4/tcp_fastopen.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
> index 8e15804..7d19fa4 100644
> --- a/net/ipv4/tcp_fastopen.c
> +++ b/net/ipv4/tcp_fastopen.c
> @@ -72,9 +72,9 @@ void tcp_fastopen_ctx_destroy(struct net *net)
>  		call_rcu(&ctxt->rcu, tcp_fastopen_ctx_free);
>  }
>  
> -struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
> -						    void *backup_key,
> -						    unsigned int len)
> +static struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
> +							   void *backup_key,
> +							   unsigned int len)
>  {
>  	struct tcp_fastopen_context *new_ctx;
>  	void *key = primary_key;
> 

Thanks for fixing.
Acked-by: Jason Baron <jbaron@...mai.com>