netdev - Re: [ovs-dev] [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2af0857-2352-9478-6f9d-87b0c1381454@gmail.com>
Date:   Mon, 10 Jun 2019 14:13:42 -0700
From:   Gregory Rose <gvrose8192@...il.com>
To:     Taehee Yoo <ap420073@...il.com>, davem@...emloft.net,
        pshelar@....org, netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [ovs-dev] [PATCH net-next] net: openvswitch: remove unnecessary
 ASSERT_OVSL in ovs_vport_del()


On 6/9/2019 10:19 AM, Taehee Yoo wrote:
> ASSERT_OVSL() in ovs_vport_del() is unnecessary because
> ovs_vport_del() is only called by ovs_dp_detach_port() and
> ovs_dp_detach_port() calls ASSERT_OVSL() too.
>
> Signed-off-by: Taehee Yoo <ap420073@...il.com>
> ---
>   net/openvswitch/vport.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> index 258ce3b7b452..9e71f1a601a9 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options)
>    */
>   void ovs_vport_del(struct vport *vport)
>   {
> -	ASSERT_OVSL();
> -
>   	hlist_del_rcu(&vport->hash_node);
>   	module_put(vport->ops->owner);
>   	vport->ops->destroy(vport);

LGTM
Reviewed-by: Greg Rose <gvrose8192@...il.com>