netdev - Re: [PATCH v2 bpf] bpf: lpm_trie: check left child of last leftmost node for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190610213349.de7wfhvo73my4kpp@kafai-mbp.dhcp.thefacebook.com>
Date:   Mon, 10 Jun 2019 21:33:53 +0000
From:   Martin Lau <kafai@...com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
CC:     Yonghong Song <yhs@...com>, "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 bpf] bpf: lpm_trie: check left child of last leftmost
 node for NULL

On Sat, Jun 08, 2019 at 12:54:19PM -0700, Jonathan Lemon wrote:
> If the leftmost parent node of the tree has does not have a child
> on the left side, then trie_get_next_key (and bpftool map dump) will
> not look at the child on the right.  This leads to the traversal
> missing elements.
Good catch!

Acked-by: Martin KaFai Lau <kafai@...com>