netdev - Re: [PATCH v2 bpf] bpf: lpm_trie: check left child of last leftmost node for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c739d394-0267-d032-a1d7-a85aa57d9274@iogearbox.net>
Date:   Tue, 11 Jun 2019 10:24:29 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jonathan Lemon <jonathan.lemon@...il.com>, yhs@...com,
        ast@...nel.org
Cc:     kernel-team@...com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 bpf] bpf: lpm_trie: check left child of last leftmost
 node for NULL

On 06/08/2019 09:54 PM, Jonathan Lemon wrote:
> If the leftmost parent node of the tree has does not have a child
> on the left side, then trie_get_next_key (and bpftool map dump) will
> not look at the child on the right.  This leads to the traversal
> missing elements.
> 
> Lookup is not affected.
> 
> Update selftest to handle this case.
> 
> Reproducer:
> 
>  bpftool map create /sys/fs/bpf/lpm type lpm_trie key 6 \
>      value 1 entries 256 name test_lpm flags 1
>  bpftool map update pinned /sys/fs/bpf/lpm key  8 0 0 0  0   0 value 1
>  bpftool map update pinned /sys/fs/bpf/lpm key 16 0 0 0  0 128 value 2
>  bpftool map dump   pinned /sys/fs/bpf/lpm
> 
> Returns only 1 element. (2 expected)
> 
> Fixes: b471f2f1de8 ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE")
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

Applied, thanks!