netdev - Re: [PATCH RFC 09/13] net: phy: marvell: Add cable test support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c74f9b02-2e1d-8b85-d7b2-ad379df8601e@gmail.com>
Date:   Wed, 12 Jun 2019 20:08:39 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, netdev <netdev@...r.kernel.org>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Raju.Lakkaraju@...rochip.com
Subject: Re: [PATCH RFC 09/13] net: phy: marvell: Add cable test support



On 6/12/2019 9:05 AM, Andrew Lunn wrote:
> The Marvell PHYs have a couple of different register sets for
> performing cable tests. Page 7 provides the simplest to use. However,
> it does not provide cable length, only length to a fault, when there
> is a fault.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
[snip]

> + 	bmcr = phy_read(phydev, MII_BMCR);
> +	if (bmcr < 0)
> +		return bmcr;
> +
> +	bmsr = phy_read(phydev, MII_BMCR);

Should this second read be for MII_BMSR?
-- 
Florian