netdev - Re: [iproute2 net-next PATCH] ip: add a new parameter -Numeric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190613030722.GD18865@dhcp-12-139.nay.redhat.com>
Date:   Thu, 13 Jun 2019 11:07:22 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Phil Sutter <phil@....cc>
Subject: Re: [iproute2 net-next PATCH] ip: add a new parameter -Numeric

Hi Roman,
On Wed, Jun 12, 2019 at 12:01:20PM -0400, Roman Mashak wrote:
> Hangbin Liu <liuhangbin@...il.com> writes:
> 
> > Add a new parameter '-Numeric' to show the number of protocol, scope,
> > dsfield, etc directly instead of converting it to human readable name.
> > Do the same on tc and ss.
> >
> > This patch is based on David Ahern's previous patch.
> >
> 
> [...]
> 
> It would be good idea to specify the numerical format, e.g. hex or dec,
> very often hex is more conveninet representation (for example, when
> skbmark is encoded of IP address or such).

Some functions use hex and some functions use integer. It's looks hard to
unit all functions.

I tried to make all the functions use itself printf to keep the compatibility.
Only changed function nl_proto_n2a as it was only called by ss, and we
removed function nl_proto_n2a.

Thanks
Hangbin
> 
> Could you think of extending it '-Numeric' to have an optional argument
> hex, and use decimal as default.