netdev - Re: [iproute2 net-next PATCH] ip: add a new parameter -Numeric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8bb54a4-604e-3082-c0bb-70c2ac1548b2@gmail.com>
Date:   Fri, 14 Jun 2019 08:04:23 -0600
From:   David Ahern <dsahern@...il.com>
To:     Roman Mashak <mrv@...atatu.com>, Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        Phil Sutter <phil@....cc>
Subject: Re: [iproute2 net-next PATCH] ip: add a new parameter -Numeric

On 6/12/19 10:01 AM, Roman Mashak wrote:
> Hangbin Liu <liuhangbin@...il.com> writes:
> 
>> Add a new parameter '-Numeric' to show the number of protocol, scope,
>> dsfield, etc directly instead of converting it to human readable name.
>> Do the same on tc and ss.
>>
>> This patch is based on David Ahern's previous patch.
>>
> 
> [...]
> 
> It would be good idea to specify the numerical format, e.g. hex or dec,
> very often hex is more conveninet representation (for example, when
> skbmark is encoded of IP address or such).
> 
> Could you think of extending it '-Numeric' to have an optional argument
> hex, and use decimal as default.
> 

I do not see how such an option could work. It would be best for
iproute2 commands to output fields as hex or decimal based on what makes
sense for each. That said, I do not see how this patch affects fields
such as skbmark. Can you give an example? The patch looks fine to me.