netdev - Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Jun 2019 12:59:41 +0100
From:   John Hurley <john.hurley@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Simon Horman <simon.horman@...ronome.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions
 to TC

On Fri, Jun 14, 2019 at 9:10 AM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Thu, Jun 13, 2019 at 07:43:57PM CEST, john.hurley@...ronome.com wrote:
> >Currently, TC offers the ability to match on the MPLS fields of a packet
> >through the use of the flow_dissector_key_mpls struct. However, as yet, TC
> >actions do not allow the modification or manipulation of such fields.
> >
> >Add a new module that registers TC action ops to allow manipulation of
> >MPLS. This includes the ability to push and pop headers as well as modify
> >the contents of new or existing headers. A further action to decrement the
> >TTL field of an MPLS header is also provided.
> >
> >Signed-off-by: John Hurley <john.hurley@...ronome.com>
> >Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>
> [...]
>
>
> >+              if (tb[TCA_MPLS_LABEL] || tb[TCA_MPLS_TTL] || tb[TCA_MPLS_TC]) {
> >+                      NL_SET_ERR_MSG_MOD(extack,
> >+                                         "MPLS POP: unsupported attrs");
>
> No need to break line here and couple other similar places in this code.
> Anyway, looks good otherwise:
>

Ok, let me respin with these line breaks removed.
I'll also retract patch 2 and repost when driver changes are there.
Thanks


> Acked-by: Jiri Pirko <jiri@...lanox.com>
>
> [...]