netdev - Re: [PATCH net-next v2 2/3] net: sched: include mpls actions in hardware intermediate representation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614081120.GD2242@nanopsycho>
Date:   Fri, 14 Jun 2019 10:11:20 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     John Hurley <john.hurley@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        xiyou.wangcong@...il.com, dcaratti@...hat.com,
        simon.horman@...ronome.com, jakub.kicinski@...ronome.com,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v2 2/3] net: sched: include mpls actions in
 hardware intermediate representation

Thu, Jun 13, 2019 at 07:43:58PM CEST, john.hurley@...ronome.com wrote:
>A recent addition to TC actions is the ability to manipulate the MPLS
>headers on packets.
>
>In preparation to offload such actions to hardware, update the IR code to
>accept and prepare the new actions.
>
>Signed-off-by: John Hurley <john.hurley@...ronome.com>
>Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>---
> include/net/flow_offload.h   | 10 +++++++
> include/net/tc_act/tc_mpls.h | 64 ++++++++++++++++++++++++++++++++++++++++++++
> net/sched/cls_api.c          | 26 ++++++++++++++++++
> 3 files changed, 100 insertions(+)
>
>diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
>index 36fdb85..e26ae81 100644
>--- a/include/net/flow_offload.h
>+++ b/include/net/flow_offload.h
>@@ -123,6 +123,10 @@ enum flow_action_id {
> 	FLOW_ACTION_QUEUE,
> 	FLOW_ACTION_SAMPLE,
> 	FLOW_ACTION_POLICE,
>+	FLOW_ACTION_MPLS_PUSH,
>+	FLOW_ACTION_MPLS_POP,
>+	FLOW_ACTION_MPLS_MANGLE,
>+	FLOW_ACTION_MPLS_DEC_TTL,
> };
> 
> /* This is mirroring enum pedit_header_type definition for easy mapping between
>@@ -172,6 +176,12 @@ struct flow_action_entry {
> 			s64			burst;
> 			u64			rate_bytes_ps;
> 		} police;
>+		struct {				/* FLOW_ACTION_MPLS */
>+			u32		label;
>+			__be16		proto;
>+			u8		tc;
>+			u8		ttl;
>+		} mpls;


This patch is not really useful without a driver offloading this...

[...]