netdev - Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614081004.GC2242@nanopsycho>
Date:   Fri, 14 Jun 2019 10:10:04 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     John Hurley <john.hurley@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        xiyou.wangcong@...il.com, dcaratti@...hat.com,
        simon.horman@...ronome.com, jakub.kicinski@...ronome.com,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation
 actions to TC

Thu, Jun 13, 2019 at 07:43:57PM CEST, john.hurley@...ronome.com wrote:
>Currently, TC offers the ability to match on the MPLS fields of a packet
>through the use of the flow_dissector_key_mpls struct. However, as yet, TC
>actions do not allow the modification or manipulation of such fields.
>
>Add a new module that registers TC action ops to allow manipulation of
>MPLS. This includes the ability to push and pop headers as well as modify
>the contents of new or existing headers. A further action to decrement the
>TTL field of an MPLS header is also provided.
>
>Signed-off-by: John Hurley <john.hurley@...ronome.com>
>Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

[...]


>+		if (tb[TCA_MPLS_LABEL] || tb[TCA_MPLS_TTL] || tb[TCA_MPLS_TC]) {
>+			NL_SET_ERR_MSG_MOD(extack,
>+					   "MPLS POP: unsupported attrs");

No need to break line here and couple other similar places in this code.
Anyway, looks good otherwise:

Acked-by: Jiri Pirko <jiri@...lanox.com>

[...]