netdev - Re: [PATCH v2 2/5] objtool: Fix ORC unwinding in non-JIT BPF generated code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR02MB57042A4F3AAA334A6349643183E90@BYAPR02MB5704.namprd02.prod.outlook.com>
Date:   Sat, 15 Jun 2019 00:06:22 +0000
From:   abhja kaanlani <unidef_rogue@...e.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
CC:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        X86 ML <x86@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>,
        Song Liu <songliubraving@...com>,
        Kairui Song <kasong@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        "David Laight" <David.Laight@...lab.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v2 2/5] objtool: Fix ORC unwinding in non-JIT BPF
 generated code

Maybe add more multidimensional arrays? 

Sent from my iPhone

>> On Jun 14, 2019, at 5:02 PM, Josh Poimboeuf <jpoimboe@...hat.com> wrote:
>> 
>>> On Fri, Jun 14, 2019 at 04:30:15PM -0700, Alexei Starovoitov wrote:
>>>> On Fri, Jun 14, 2019 at 4:17 PM Josh Poimboeuf <jpoimboe@...hat.com> wrote:
>>>> 
>>>> On Fri, Jun 14, 2019 at 02:22:59PM -0700, Alexei Starovoitov wrote:
>>>> On Fri, Jun 14, 2019 at 2:19 PM Josh Poimboeuf <jpoimboe@...hat.com> wrote:
>>>>>>>>> 
>>>>>>>>> +#define JUMP_TABLE_SYM_PREFIX "jump_table."
>>>>>>>> 
>>>>>>>> since external tool will be looking at it should it be named
>>>>>>>> "bpf_jump_table." to avoid potential name conflicts?
>>>>>>>> Or even more unique name?
>>>>>>>> Like "bpf_interpreter_jump_table." ?
>>>>>>> 
>>>>>>> No, the point is that it's a generic feature which can also be used any
>>>>>>> non-BPF code which might also have a jump table.
>>>>>> 
>>>>>> and you're proposing to name all such jump tables in the kernel
>>>>>> as static foo jump_table[] ?
>>>>> 
>>>>> That's the idea.
>>>> 
>>>> Then it needs much wider discussion.
>>> 
>>> Why would it need wider discussion?  It only has one user.  If you
>>> honestly believe that it will be controversial to require future users
>>> to call a static jump table "jump_table" then we can have that
>>> discussion when it comes up.
>> 
>> It's clearly controversial.
>> I nacked it already on pointless name change
>> from "jumptable" to "jump_table" and now you're saying
>> that no one will complain about "jump_table" name
>> for all jump tables in the kernel that will ever appear?
> 
> Let me get this straight.  You're saying that "jumptable" and
> "bpf_interpreter_jump_table" are both acceptable.
> 
> But NACK to "jump_table".
> 
> Ok...
> 
> -- 
> Josh