netdev - Re: [PATCH net] bnx2x: Check if transceiver implements DDM before access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190616.133904.49117769286698801.davem@davemloft.net>
Date:   Sun, 16 Jun 2019 13:39:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maurosr@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, aelior@...vell.com, skalluru@...vell.com,
        GR-everest-linux-l2@...vell.com
Subject: Re: [PATCH net] bnx2x: Check if transceiver implements DDM before
 access

From: "Mauro S. M. Rodrigues" <maurosr@...ux.vnet.ibm.com>
Date: Thu, 13 Jun 2019 16:25:40 -0300

> Some transceivers may comply with SFF-8472 even though they do not
> implement the Digital Diagnostic Monitoring (DDM) interface described in
> the spec. The existence of such area is specified by the 6th bit of byte
> 92, set to 1 if implemented.
> 
> Currently, without checking this bit, bnx2x fails trying to read sfp
> module's EEPROM with the follow message:
> 
> ethtool -m enP5p1s0f1
> Cannot get Module EEPROM data: Input/output error
> 
> Because it fails to read the additional 256 bytes in which it is assumed
> to exist the DDM data.
> 
> This issue was noticed using a Mellanox Passive DAC PN 01FT738. The EEPROM
> data was confirmed by Mellanox as correct and similar to other Passive
> DACs from other manufacturers.
> 
> Signed-off-by: Mauro S. M. Rodrigues <maurosr@...ux.vnet.ibm.com>

Marvell folks, please review.