netdev - Re: [PATCH net v2] net: handle 802.1P vlan 0 packets properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190616.134529.452171251313252288.davem@davemloft.net>
Date:   Sun, 16 Jun 2019 13:45:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gvaradar@...co.com
Cc:     benve@...co.com, netdev@...r.kernel.org, govind.varadar@...il.com,
        ssuryaextr@...il.com, toshiaki.makita1@...il.com
Subject: Re: [PATCH net v2] net: handle 802.1P vlan 0 packets properly

From: Govindarajulu Varadarajan <gvaradar@...co.com>
Date: Fri, 14 Jun 2019 06:13:54 -0700

> When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4],
> vlan_do_receive() returns false if it does not find vlan_dev. Later
> __netif_receive_skb_core() fails to find packet type handler for
> skb->protocol 801.1AD and drops the packet.
> 
> 801.1P header with vlan id 0 should be handled as untagged packets.
> This patch fixes it by checking if vlan_id is 0 and processes next vlan
> header.
> 
> Signed-off-by: Govindarajulu Varadarajan <gvaradar@...co.com>
> ---
> v2:	Move the check out of vlan_do_receive() to
> 	__netif_receive_skb_core(). This way, we do not change the
> 	behaviour when rx_handler is registered. i.e do not strip off
> 	802.1P header when bridge (or rx_handler) is registered.
> 
> Previous discussions:
> http://patchwork.ozlabs.org/patch/1113413/
> http://patchwork.ozlabs.org/patch/1113347/

Looks good, applied, thanks.