netdev - Re: [PATCH net-next v3 7/7] net: ipv4: provide __rcu annotation for ifa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04a5f0ab-00b7-7ba9-2842-915479abe6be@mellanox.com>
Date:   Mon, 17 Jun 2019 08:25:41 +0000
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Florian Westphal <fw@...len.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Eric Dumazet <edumazet@...gle.com>,
        Ran Rozenstein <ranro@...lanox.com>,
        Maor Gottlieb <maorg@...lanox.com>
Subject: Re: [PATCH net-next v3 7/7] net: ipv4: provide __rcu annotation for
 ifa_list



On 5/31/2019 7:27 PM, Florian Westphal wrote:
> ifa_list is protected by rcu, yet code doesn't reflect this.
> 
> Add the __rcu annotations and fix up all places that are now reported by
> sparse.
> 
> I've done this in the same commit to not add intermediate patches that
> result in new warnings.
> 
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Florian Westphal <fw@...len.de>

Hi Florian,

Our verification team bisected a degradation [1], seems to be in this patch.
I see you already posted one fix for it [2], but it does not solve.
Any idea?

Regards,
Tariq


[2] d3e6e285fff3 net: ipv4: fix rcu lockdep splat due to wrong annotation

[1]

[2019-06-11 22:38:19] mlx5_core 0000:00:08.1 ens8f1: Link up
[2019-06-11 22:38:19] 8021q: adding VLAN 0 to HW filter on device ens8f1
[2019-06-11 22:38:47] watchdog: BUG: soft lockup - CPU#4 stuck for 22s! 
[ifconfig:32042]
[2019-06-11 22:38:47] Modules linked in: rdma_ucm rdma_cm iw_cm ib_ipoib 
ib_cm ib_umad mlx5_ib mlx5_core mlxfw mlx4_ib ib_uverbs ib_core mlx4_en 
ptp pps_core mlx4_core 8021q garp stp mrp llc mst_pciconf(OE) nfsv3 
nfs_acl nfs lockd grace fscache netconsole cfg80211 rfkill sunrpc 
snd_hda_codec_generic ledtrig_audio snd_hda_intel snd_hda_codec 
snd_hda_core cirrus drm_kms_helper snd_hwdep snd_seq crc32_pclmul 
snd_seq_device ghash_clmulni_intel drm snd_pcm snd_timer snd syscopyarea 
sysfillrect soundcore sysimgblt i2c_piix4 pcspkr fb_sys_fops i2c_core 
sch_fq_codel ip_tables ata_generic pata_acpi virtio_net crc32c_intel 
net_failover serio_raw failover ata_piix floppy [last unloaded: mlx4_core]
[2019-06-11 22:38:47] CPU: 4 PID: 32042 Comm: ifconfig Tainted: G 
    OE     5.2.0-rc4-for-upstream-perf-2019-06-11_15-08-06-31 #1
[2019-06-11 22:38:47] Hardware name: QEMU Standard PC (i440FX + PIIX, 
1996), BIOS 1.10.2-1ubuntu1 04/01/2014
[2019-06-11 22:38:47] RIP: 0010:__inet_del_ifa+0xa5/0x300
[2019-06-11 22:38:47] Code: 5e 10 45 31 d2 eb 13 0f b6 43 44 41 38 46 44 
4c 0f 46 cb 4c 8d 5b 10 49 89 da 49 8b 1b 48 85 db 0f 84 98 00 00 00 f6 
43 48 01 <74> db 41 8b 46 38 3b 43 38 75 de 8b 53 34 41 33 56 34 85 c2 75 d3
[2019-06-11 22:38:47] RSP: 0018:ffffc90002cafc28 EFLAGS: 00000246 
ORIG_RAX: ffffffffffffff13
[2019-06-11 22:38:47] RAX: 0000000000000000 RBX: ffff888291eb9880 RCX: 
0000000000000000
[2019-06-11 22:38:47] RDX: 0000000000000000 RSI: 0000000000000001 RDI: 
ffff88835c39a000
[2019-06-11 22:38:47] RBP: 0000000000000000 R08: 0000000000000000 R09: 
ffff888291eb9880
[2019-06-11 22:38:47] R10: ffff888291eb9880 R11: ffff888291eb9890 R12: 
0000000000000000
[2019-06-11 22:38:47] R13: ffff88835c39a010 R14: ffff88827bb7c680 R15: 
0000000000000001
[2019-06-11 22:38:47] FS:  00007fd1c0d82740(0000) 
GS:ffff88835f700000(0000) knlGS:0000000000000000
[2019-06-11 22:38:47] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[2019-06-11 22:38:47] CR2: 00007f9781165160 CR3: 0000000276a52000 CR4: 
00000000000006e0
[2019-06-11 22:38:47] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 
0000000000000000
[2019-06-11 22:38:47] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 
0000000000000400
[2019-06-11 22:38:47] Call Trace:
[2019-06-11 22:38:47]  devinet_ioctl+0x1fa/0x720
[2019-06-11 22:38:47]  inet_ioctl+0x93/0x150
[2019-06-11 22:38:47]  ? page_add_file_rmap+0x15/0x180
[2019-06-11 22:38:47]  ? alloc_set_pte+0x12c/0x580
[2019-06-11 22:38:47]  sock_do_ioctl+0x3d/0x130
[2019-06-11 22:38:47]  ? filemap_map_pages+0xf2/0x3b0
[2019-06-11 22:38:47]  sock_ioctl+0x1e5/0x390
[2019-06-11 22:38:47]  ? __handle_mm_fault+0xae4/0xe80
[2019-06-11 22:38:47]  do_vfs_ioctl+0xa6/0x600
[2019-06-11 22:38:47]  ksys_ioctl+0x60/0x90
[2019-06-11 22:38:47]  __x64_sys_ioctl+0x16/0x20
[2019-06-11 22:38:47]  do_syscall_64+0x48/0x130
[2019-06-11 22:38:47]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[2019-06-11 22:38:47] RIP: 0033:0x7fd1c0899dc7
[2019-06-11 22:38:47] Code: b3 66 90 48 8b 05 d9 00 2d 00 64 c7 00 26 00 
00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 
00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a9 00 2d 00 f7 d8 64 89 01 48
[2019-06-11 22:38:47] RSP: 002b:00007fff995c4758 EFLAGS: 00000246 
ORIG_RAX: 0000000000000010
[2019-06-11 22:38:47] RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 
00007fd1c0899dc7
[2019-06-11 22:38:47] RDX: 00007fff995c47c0 RSI: 0000000000008916 RDI: 
000000000000000c
[2019-06-11 22:38:47] RBP: 00007fff995c5be7 R08: 00007fff995c48fd R09: 
0000000000000000
[2019-06-11 22:38:47] R10: 00007fd1c091e880 R11: 0000000000000246 R12: 
0000000000000005
[2019-06-11 22:38:47] R13: 00007fff995c4aa8 R14: 0000000000000000 R15: 
0000000000000000