netdev - Re: [PATCH net-next v3 7/7] net: ipv4: provide __rcu annotation for ifa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190617092501.vu3trkq4nvgkkilv@breakpoint.cc>
Date:   Mon, 17 Jun 2019 11:25:01 +0200
From:   Florian Westphal <fw@...len.de>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     Florian Westphal <fw@...len.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Ran Rozenstein <ranro@...lanox.com>,
        Maor Gottlieb <maorg@...lanox.com>
Subject: Re: [PATCH net-next v3 7/7] net: ipv4: provide __rcu annotation for
 ifa_list

Tariq Toukan <tariqt@...lanox.com> wrote:
> On 5/31/2019 7:27 PM, Florian Westphal wrote:
> > ifa_list is protected by rcu, yet code doesn't reflect this.
> > 
> > Add the __rcu annotations and fix up all places that are now reported by
> > sparse.
> > 
> > I've done this in the same commit to not add intermediate patches that
> > result in new warnings.
> > 
> > Reported-by: Eric Dumazet <edumazet@...gle.com>
> > Signed-off-by: Florian Westphal <fw@...len.de>
> 
> Hi Florian,
> 
> Our verification team bisected a degradation [1], seems to be in this patch.
> I see you already posted one fix for it [2], but it does not solve.
> Any idea?

Thanks for the report, is there are reproducer?

> [2019-06-11 22:38:19] 8021q: adding VLAN 0 to HW filter on device ens8f1
> [2019-06-11 22:38:47] watchdog: BUG: soft lockup - CPU#4 stuck for 22s! 
> [ifconfig:32042]

> [2019-06-11 22:38:47] RIP: 0010:__inet_del_ifa+0xa5/0x300

I will have look later today.