netdev - Re: next/master boot bisection: next-20190617 on sun8i-h2-plus-orangepi-zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2af9b9a5-cdf8-afce-5a75-d66c99eb82a2@collabora.com>
Date:   Tue, 18 Jun 2019 22:07:06 +0100
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     Kevin Hilman <khilman@...libre.com>,
        "David S. Miller" <davem@...emloft.net>,
        tomeu.vizoso@...labora.com, mgalka@...labora.com,
        broonie@...nel.org, matthew.hart@...aro.org,
        enric.balletbo@...labora.com, Jose Abreu <joabreu@...opsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: next/master boot bisection: next-20190617 on
 sun8i-h2-plus-orangepi-zero

Hi Martin,

On 18/06/2019 21:58, Martin Blumenstingl wrote:
> Hi Guillaume,
> 
> On Tue, Jun 18, 2019 at 10:53 PM Guillaume Tucker
> <guillaume.tucker@...labora.com> wrote:
>>
>> On 18/06/2019 21:42, Martin Blumenstingl wrote:
>>> On Tue, Jun 18, 2019 at 6:53 PM Kevin Hilman <khilman@...libre.com> wrote:
>>> [...]
>>>> This seems to have broken on several sunxi SoCs, but also a MIPS SoC
>>>> (pistachio_marduk):
>>>>
>>>> https://storage.kernelci.org/next/master/next-20190618/mips/pistachio_defconfig/gcc-8/lab-baylibre-seattle/boot-pistachio_marduk.html
>>> today I learned why initializing arrays on the stack is important
>>> too bad gcc didn't warn that I was about to shoot myself (or someone
>>> else) in the foot :/
>>>
>>> I just sent a fix: [0]
>>>
>>> sorry for this issue and thanks to Kernel CI for even pointing out the
>>> offending commit (this makes things a lot easier than just yelling
>>> that "something is broken")
>>
>> Glad that helped :)
>>
>> If you would be so kind as to credit our robot friend in your
>> patch, it'll be forever grateful:
>>
>>   Reported-by: "kernelci.org bot" <bot@...nelci.org>
> sure
> do you want me to re-send my other patch or should I just reply to it
> adding the Reported-by tag and hope that Dave will catch it when
> applying the patch?

Well that's no big deal so replying would already be great.  The
important part is that the fix gets applied.

> in either case: I did mention in the patch description that Kernel CI caught it

I see, thanks!

> by the way: I didn't know how to credit the Kernel CI bot.
> syzbot / syzkaller makes that bit easy as it's mentioned in the
> generated email, see [0] for a (random) example
> have you considered adding the Reported-by to the generated email?

Yes, we've got some bugs to fix first but that will be added to
the email report soon (next week I guess).  Thanks for the
suggestion though.

Guillaume

> [0] https://lkml.org/lkml/2019/4/19/638