netdev - Re: [PATCH net-next v3 4/6] taprio: Add support for txtime-assist mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0EE3B2CB-5EEA-47B5-B90D-A74177A04570@intel.com>
Date:   Wed, 19 Jun 2019 16:54:32 +0000
From:   "Patel, Vedang" <vedang.patel@...el.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "l@...ileo.org" <l@...ileo.org>
Subject: Re: [PATCH net-next v3 4/6] taprio: Add support for txtime-assist
 mode.

Thanks for the input David. 


> On Jun 17, 2019, at 4:22 PM, David Miller <davem@...emloft.net> wrote:
> 
> From: Vedang Patel <vedang.patel@...el.com>
> Date: Mon, 17 Jun 2019 12:31:08 -0700
> 
>> diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
>> index a41d7d4434ee..ab6080013666 100644
>> --- a/net/sched/sch_taprio.c
>> +++ b/net/sched/sch_taprio.c
> ...
>> +/* Get how much time has been already elapsed in the current cycle. */
>> +static inline s32 get_cycle_time_elapsed(struct sched_gate_list *sched, ktime_t time)
>> +{
> 
> Please do not use the inline directive in foo.c files, let the compiler decide.
> 
Okay, I will remove inline directive from all C files and send a new version.

-Vedang
> ...
>> +static inline int length_to_duration(struct taprio_sched *q, int len)
>> +{
>> +	return (len * atomic64_read(&q->picos_per_byte)) / 1000;
>> +}
> 
> Likewise.
> 
> ...
>> +static inline ktime_t get_cycle_start(struct sched_gate_list *sched,
>> +				      ktime_t time)
>> +{
> 
> Likewise.