netdev - Re: [PATCH net-next v3 2/6] etf: Add skip_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6AA5A401-97AE-47D6-BD0D-2746C4FE3DAE@intel.com>
Date:   Wed, 19 Jun 2019 16:55:47 +0000
From:   "Patel, Vedang" <vedang.patel@...el.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        David Miller <davem@...emloft.net>,
        "Jamal Hadi Salim" <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "l@...ileo.org" <l@...ileo.org>
Subject: Re: [PATCH net-next v3 2/6] etf: Add skip_sock_check

Thanks Sergei for the input.

> On Jun 18, 2019, at 2:28 AM, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
> 
> Hello!
> 
> On 17.06.2019 22:31, Vedang Patel wrote:
> 
>> Currently, etf expects a socket with SO_TXTIME option set for each packet
>> it encounters. So, it will drop all other packets. But, in the future
>> commits we are planning to add functionality which where tstamp value will
>> be set by another qdisc. Also, some packets which are generated from within
>> the kernel (e.g. ICMP packets) do not have any socket associated with them.
>> So, this commit adds support for skip_sock_check. When this option is set,
>> etf will skip checking for a socket and other associated options for all
>> skbs.
>> Signed-off-by: Vedang Patel <vedang.patel@...el.com>
>> ---
>>  include/uapi/linux/pkt_sched.h |  1 +
>>  net/sched/sch_etf.c            | 10 ++++++++++
>>  2 files changed, 11 insertions(+)
>> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
>> index 8b2f993cbb77..69fc52e4d6bd 100644
>> --- a/include/uapi/linux/pkt_sched.h
>> +++ b/include/uapi/linux/pkt_sched.h
>> @@ -990,6 +990,7 @@ struct tc_etf_qopt {
>>  	__u32 flags;
>>  #define TC_ETF_DEADLINE_MODE_ON	BIT(0)
>>  #define TC_ETF_OFFLOAD_ON	BIT(1)
>> +#define TC_ETF_SKIP_SOCK_CHECK  BIT(2)
> 
>  Please indent with a tab like above, not 2 spaces.
> 
I will include this in the next version.

-Vedang
> [...]
> 
> MBR, Sergei