netdev - Re: [PATCH net-next v2 1/1] net: fastopen: robustness and endianness fixes for SipHash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190619.174234.2210089047219514238.davem@davemloft.net>
Date:   Wed, 19 Jun 2019 17:42:34 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ard.biesheuvel@...aro.org
Cc:     netdev@...r.kernel.org, ebiggers@...nel.org,
        linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
        edumazet@...gle.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        jbaron@...mai.com, cpaasch@...le.com, David.Laight@...lab.com,
        ycheng@...gle.com
Subject: Re: [PATCH net-next v2 1/1] net: fastopen: robustness and
 endianness fixes for SipHash

From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Date: Wed, 19 Jun 2019 08:55:10 +0200

> +	ctx->key[0] = (siphash_key_t){
> +		get_unaligned_le64(primary_key),
> +		get_unaligned_le64(primary_key + 8)
> +	};

Please just use normal assignment(s), because not only does this warn
it looks not so nice.

Thanks.