netdev - Re: [PATCH net-next v2 1/1] net: fastopen: robustness and endianness fixes for SipHash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jun 2019 23:47:19 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     David Miller <davem@...emloft.net>
Cc:     "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
        Eric Biggers <ebiggers@...nel.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jason Baron <jbaron@...mai.com>,
        Christoph Paasch <cpaasch@...le.com>,
        David Laight <David.Laight@...lab.com>,
        Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net-next v2 1/1] net: fastopen: robustness and endianness
 fixes for SipHash

On Wed, 19 Jun 2019 at 23:42, David Miller <davem@...emloft.net> wrote:
>
> From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Date: Wed, 19 Jun 2019 08:55:10 +0200
>
> > +     ctx->key[0] = (siphash_key_t){
> > +             get_unaligned_le64(primary_key),
> > +             get_unaligned_le64(primary_key + 8)
> > +     };
>
> Please just use normal assignment(s), because not only does this warn
> it looks not so nice.
>

OK

Please disregard the v3 I just sent out, v4 has ordinary assignments.