netdev - Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190624.080401.605091064881218530.davem@davemloft.net>
Date:   Mon, 24 Jun 2019 08:04:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Igor.Russkikh@...antia.com
Cc:     jakub.kicinski@...ronome.com, andrew@...n.ch,
        netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH net-next 1/7] net: aquantia: replace internal driver
 version code with uts

From: Igor Russkikh <Igor.Russkikh@...antia.com>
Date: Mon, 24 Jun 2019 11:02:54 +0000

> 
>> 
>>> Devlink has just gained something similar to ethtool -i. Maybe we
>>> should get the devlink core to also report the kernel version?
>> 
>> I don't think we have the driver version at all there, my usual
>> inclination being to not duplicate information across APIs.  Do we 
>> have non-hypothetical instances of users reporting ethtool -i without
>> uname output?  Admittedly I may work with above-average Linux-trained
>> engineers :S  Would it be okay to just get devlink user space to use
>> uname() to get the info?
> 
> I work alot with field support engineering people, they have a 'NIC-centric'
> view on a system and often assume NIC driver version is all that matters.
> 
> Therefore `ethtool -i` is often the only thing we get when debugging user issues.

This is an education issue, not one of what we should be doing in the
kernel.