netdev - Re: [PATCH net-next 2/7] net: aquantia: add documentation for the atlantic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7017d220-f47a-b2cb-f54f-29b42eed8930@aquantia.com>
Date:   Mon, 24 Jun 2019 11:17:23 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/7] net: aquantia: add documentation for the
 atlantic driver


>> +  increase the MTU size.  For example:
>> +
>> +        ifconfig <ethX> mtu 16000 up
> 
> ifconfig has been deprecated for many years. Please document the
> iproute2 command.

Thanks for review, Andrew, yep, will update that.

>> + supports-priv-flags: no
> 
> Shouldn't there be 5.2-rc5 in here somewhere, given the first patch in
> this series?

Good catch )

>> + Disable GRO when routing/bridging
>> + ---------------------------------
>> + Due to a known kernel issue, GRO must be turned off when routing/bridging.
>> + It can be done with command:
> 
> Is this a kernel issue, or a driver issue? 

Hm, honestly I've just copy pasted that section from our old driver spec.
Checked this, for now I see that networking core by itself takes actions to
disable LRO/GRO on device when its not appropriate, for example when ip4
forwarding is enabled.

May be that was a case with older kernels. Will remove these LRO/GRO notices.

>> + To disable coalescing:
>> +
>> + ethtool -C <ethX> tx-usecs 0 rx-usecs 0 tx-max-frames 1 tx-max-frames 1
> 
> Please put these before the module parameters. We should discourage
> the use of module parameters. Using ethtool is the correct way to do
> this.

Ok,

> 
> grep SPDX drivers/net/ethernet/aquantia/atlantic/*.c
> drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.c:// SPDX-License-Identifier: GPL-2.0-or-later
> drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:// SPDX-License-Identifier: GPL-2.0-only
> drivers/net/ethernet/aquantia/atlantic/aq_filters.c:// SPDX-License-Identifier: GPL-2.0-or-later
> drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.c:// SPDX-License-Identifier: GPL-2.0-only
> drivers/net/ethernet/aquantia/atlantic/aq_main.c:// SPDX-License-Identifier: GPL-2.0-only
> drivers/net/ethernet/aquantia/atlantic/aq_nic.c:// SPDX-License-Identifier: GPL-2.0-only
> drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:// SPDX-License-Identifier: GPL-2.0-only
> drivers/net/ethernet/aquantia/atlantic/aq_ring.c:// SPDX-License-Identifier: GPL-2.0-only
> drivers/net/ethernet/aquantia/atlantic/aq_vec.c:// SPDX-License-Identifier: GPL-2.0-only
> 
> You have a mix of 2 and 2+.

Thanks, will clean this up.

Regards,
  Igor