netdev - Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <120088f1-c860-a643-c675-fdeed4faf1ef@aquantia.com>
Date:   Mon, 24 Jun 2019 11:02:54 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next 1/7] net: aquantia: replace internal driver
 version code with uts


> 
>> Devlink has just gained something similar to ethtool -i. Maybe we
>> should get the devlink core to also report the kernel version?
> 
> I don't think we have the driver version at all there, my usual
> inclination being to not duplicate information across APIs.  Do we 
> have non-hypothetical instances of users reporting ethtool -i without
> uname output?  Admittedly I may work with above-average Linux-trained
> engineers :S  Would it be okay to just get devlink user space to use
> uname() to get the info?

I work alot with field support engineering people, they have a 'NIC-centric'
view on a system and often assume NIC driver version is all that matters.

Therefore `ethtool -i` is often the only thing we get when debugging user issues.

Regards,
  Igor