netdev - Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190623204954.3aa09ded@cakuba>
Date:   Sun, 23 Jun 2019 20:49:54 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Igor Russkikh <Igor.Russkikh@...antia.com>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next 1/7] net: aquantia: replace internal driver
 version code with uts

On Sat, 22 Jun 2019 17:05:14 +0200, Andrew Lunn wrote:
> On Sat, Jun 22, 2019 at 01:45:12PM +0000, Igor Russkikh wrote:
> > As it was discussed some time previously, driver is better to
> > report kernel version string, as it in a best way identifies
> > the codebase.
> > 
> > Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>  
> 
> Nice.

Indeed!

> Devlink has just gained something similar to ethtool -i. Maybe we
> should get the devlink core to also report the kernel version?

I don't think we have the driver version at all there, my usual
inclination being to not duplicate information across APIs.  Do we 
have non-hypothetical instances of users reporting ethtool -i without
uname output?  Admittedly I may work with above-average Linux-trained
engineers :S  Would it be okay to just get devlink user space to use
uname() to get the info?