netdev - RE: [net-next v2] tipc: add loopback device tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR15MB3575F5AE6B64F926A5BBAB819AE00@CH2PR15MB3575.namprd15.prod.outlook.com>
Date:   Mon, 24 Jun 2019 17:45:11 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     David Miller <davem@...emloft.net>,
        John Rutherford <john.rutherford@...tech.com.au>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [net-next v2] tipc: add loopback device tracking



> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of David Miller
> Sent: 24-Jun-19 10:29
> To: John Rutherford <john.rutherford@...tech.com.au>
> Cc: netdev@...r.kernel.org
> Subject: Re: [net-next v2] tipc: add loopback device tracking
> 
> From: john.rutherford@...tech.com.au
> Date: Mon, 24 Jun 2019 16:44:35 +1000
> 
> > Since node internal messages are passed directly to socket it is not
> > possible to observe this message exchange via tcpdump or wireshark.
> >
> > We now remedy this by making it possible to clone such messages and
> > send the clones to the loopback interface.  The clones are dropped at
> > reception and have no functional role except making the traffic visible.
> >
> > The feature is turned on/off by enabling/disabling the loopback "bearer"
> > "eth:lo".
> >
> > Acked-by: Jon Maloy <jon.maloy@...csson.com>
> > Signed-off-by: John Rutherford <john.rutherford@...tech.com.au>
> 
> What a waste, just clone the packet, attach loopback to it, and go:
> 
> 	if (dev_nit_active(loopback_dev))
> 		dev_queue_xmit_nit(skb, loopback_dev);

I was never quite happy with this patch, so thank you for the feedback!

///jon