netdev - Re: [PATCH 01/15] arm: perf: cleanup cppcheck shifting error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190624071121.GN3436@hirez.programming.kicks-ass.net>
Date:   Mon, 24 Jun 2019 09:11:21 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Phong Tran <tranmanphong@...il.com>
Cc:     mark.rutland@....com, kstewart@...uxfoundation.org,
        songliubraving@...com, andrew@...n.ch, nsekhar@...com,
        ast@...nel.org, jolsa@...hat.com, netdev@...r.kernel.org,
        gerg@...inux.org, lorenzo.pieralisi@....com, will@...nel.org,
        linux-samsung-soc@...r.kernel.org, daniel@...earbox.net,
        festevam@...il.com, gregory.clement@...tlin.com,
        allison@...utok.net, linux@...linux.org.uk, krzk@...nel.org,
        haojian.zhuang@...il.com, bgolaszewski@...libre.com,
        tony@...mide.com, mingo@...hat.com, linux-imx@....com, yhs@...com,
        sebastian.hesselbarth@...il.com, illusionist.neo@...il.com,
        jason@...edaemon.net, liviu.dudau@....com, s.hauer@...gutronix.de,
        acme@...nel.org, lkundrak@...sk, robert.jarzmik@...e.fr,
        dmg@...ingmachine.org, swinslow@...il.com, namhyung@...nel.org,
        tglx@...utronix.de, linux-omap@...r.kernel.org,
        alexander.sverdlin@...il.com, linux-arm-kernel@...ts.infradead.org,
        info@...ux.net, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, alexander.shishkin@...ux.intel.com,
        hsweeten@...ionengravers.com, kgene@...nel.org,
        kernel@...gutronix.de, sudeep.holla@....com, bpf@...r.kernel.org,
        shawnguo@...nel.org, kafai@...com, daniel@...que.org
Subject: Re: [PATCH 01/15] arm: perf: cleanup cppcheck shifting error

On Sun, Jun 23, 2019 at 10:12:59PM +0700, Phong Tran wrote:
> fix "Shifting signed 32-bit value by 31 bits is undefined behaviour
> errors"
> 
> [arch/arm/kernel/perf_event_v7.c:1080]: (error) Shifting signed 32-bit
> value by 31 bits is undefined behaviour
> [arch/arm/kernel/perf_event_v7.c:1436]: (error) Shifting signed 32-bit
> value by 31 bits is undefined behaviour
> [arch/arm/kernel/perf_event_v7.c:1783]: (error) Shifting signed 32-bit
> value by 31 bits is undefined behaviour

I don't think that is true; the kernel uses -fno-strict-overflow (which
implies -fwrapv) and that takes away all the signed UB.