netdev - Re: [PATCH 10/15] ARM: orion5x: cleanup cppcheck shifting errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jun 2019 09:31:37 +0200
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Phong Tran <tranmanphong@...il.com>, mark.rutland@....com,
        kstewart@...uxfoundation.org, songliubraving@...com,
        andrew@...n.ch, peterz@...radead.org, nsekhar@...com,
        ast@...nel.org, jolsa@...hat.com, netdev@...r.kernel.org,
        gerg@...inux.org, lorenzo.pieralisi@....com, will@...nel.org,
        linux-samsung-soc@...r.kernel.org, daniel@...earbox.net,
        tranmanphong@...il.com, festevam@...il.com, allison@...utok.net,
        linux@...linux.org.uk, krzk@...nel.org, haojian.zhuang@...il.com,
        bgolaszewski@...libre.com, tony@...mide.com, mingo@...hat.com,
        linux-imx@....com, yhs@...com, sebastian.hesselbarth@...il.com,
        illusionist.neo@...il.com, jason@...edaemon.net,
        liviu.dudau@....com, s.hauer@...gutronix.de, acme@...nel.org,
        lkundrak@...sk, robert.jarzmik@...e.fr, dmg@...ingmachine.org,
        swinslow@...il.com, namhyung@...nel.org, tglx@...utronix.de,
        linux-omap@...r.kernel.org, alexander.sverdlin@...il.com,
        linux-arm-kernel@...ts.infradead.org, info@...ux.net,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        alexander.shishkin@...ux.intel.com, hsweeten@...ionengravers.com,
        kgene@...nel.org, kernel@...gutronix.de, sudeep.holla@....com,
        bpf@...r.kernel.org, shawnguo@...nel.org, kafai@...com,
        daniel@...que.org
Subject: Re: [PATCH 10/15] ARM: orion5x: cleanup cppcheck shifting errors

Hi Phong,

> [arch/arm/mach-orion5x/pci.c:281]: (error) Shifting signed 32-bit value
> by 31 bits is undefined behaviour
> [arch/arm/mach-orion5x/pci.c:305]: (error) Shifting signed 32-bit value
> by 31 bits is undefined behaviour
>

While Andrew was Ok with this version, I will wait for your v2 using
BIT() marcro.

Thanks,

Gregory


> Signed-off-by: Phong Tran <tranmanphong@...il.com>
> ---
>  arch/arm/mach-orion5x/pci.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/pci.c b/arch/arm/mach-orion5x/pci.c
> index 76951bfbacf5..1b2c077ee7b8 100644
> --- a/arch/arm/mach-orion5x/pci.c
> +++ b/arch/arm/mach-orion5x/pci.c
> @@ -200,13 +200,13 @@ static int __init pcie_setup(struct pci_sys_data *sys)
>  /*
>   * PCI_MODE bits
>   */
> -#define PCI_MODE_64BIT			(1 << 2)
> -#define PCI_MODE_PCIX			((1 << 4) | (1 << 5))
> +#define PCI_MODE_64BIT			(1U << 2)
> +#define PCI_MODE_PCIX			((1U << 4) | (1U << 5))
>  
>  /*
>   * PCI_CMD bits
>   */
> -#define PCI_CMD_HOST_REORDER		(1 << 29)
> +#define PCI_CMD_HOST_REORDER		(1U << 29)
>  
>  /*
>   * PCI_P2P_CONF bits
> @@ -223,7 +223,7 @@ static int __init pcie_setup(struct pci_sys_data *sys)
>  #define PCI_CONF_FUNC(func)		(((func) & 0x3) << 8)
>  #define PCI_CONF_DEV(dev)		(((dev) & 0x1f) << 11)
>  #define PCI_CONF_BUS(bus)		(((bus) & 0xff) << 16)
> -#define PCI_CONF_ADDR_EN		(1 << 31)
> +#define PCI_CONF_ADDR_EN		(1U << 31)
>  
>  /*
>   * Internal configuration space
> -- 
> 2.11.0
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com