netdev - Re: [net-next 2/4] gve: Add transmit and receive support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH_-1qwCjsH_Q7pXzKvPPgRYZZuk5XcWsh+9CRnfvQHtCh=gvQ@mail.gmail.com>
Date:   Fri, 28 Jun 2019 10:48:35 -0700
From:   Catherine Sullivan <csully@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Sagi Shahar <sagis@...gle.com>,
        Jon Olson <jonolson@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Luigi Rizzo <lrizzo@...gle.com>
Subject: Re: [net-next 2/4] gve: Add transmit and receive support

On Wed, Jun 26, 2019 at 12:49 PM David Miller <davem@...emloft.net> wrote:
>
> From: Catherine Sullivan <csully@...gle.com>
> Date: Wed, 26 Jun 2019 11:52:49 -0700
>
> > +#ifdef __LITTLE_ENDIAN
> > +#define GVE_SEQNO(x) ((((__force u16)x) >> 8) & 0x7)
> > +#else
> > +#define      GVE_SEQNO(x) ((__force u16)(x) & 0x7)
> > +#endif
>
> This can be simply "le16_to_cpu(x) & 0x7" or similar.  No need to
> messy ifdefs.
>

Will fix in v2.