netdev - Re: [net-next 2/4] gve: Add transmit and receive support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH_-1qwQZz5H9uQn21Vuob8PKs0-SNYh21=Q+G064OkLUUrzTQ@mail.gmail.com>
Date:   Fri, 28 Jun 2019 10:50:10 -0700
From:   Catherine Sullivan <csully@...gle.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, Sagi Shahar <sagis@...gle.com>,
        Jon Olson <jonolson@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Luigi Rizzo <lrizzo@...gle.com>
Subject: Re: [net-next 2/4] gve: Add transmit and receive support

On Wed, Jun 26, 2019 at 12:42 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +static int gve_change_mtu(struct net_device *dev, int new_mtu)
> > +{
> > +     dev->mtu = new_mtu;
> > +     return 0;
> > +}
>
> The default implementation does this.
>
> Also, i think your mtu has a limit of PAGE size.  So you should set
> the dev->max_mtu so the core will enforce this.
>
>     Andrew

Ah, thanks, gve_change_mtu will be removed in v2.
We already set dev->max_mtu to PAGE_SIZE in init_priv.