netdev - Re: [PATCH iproute2 v2 1/2] devlink: fix format string warning for 32bit targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190628152143.1378fad8@hermes.lan>
Date:   Fri, 28 Jun 2019 15:21:43 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
        Aya Levin <ayal@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>
Subject: Re: [PATCH iproute2 v2 1/2] devlink: fix format string warning for
 32bit targets

On Thu, 27 Jun 2019 21:37:18 +0300
Baruch Siach <baruch@...s.co.il> wrote:

> 32bit targets define uint64_t as long long unsigned. This leads to the
> following build warning:
> 
> devlink.c: In function ‘pr_out_u64’:
> devlink.c:1729:11: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka long long unsigned int}’ [-Wformat=]
>     pr_out("%s %lu", name, val);
>            ^
> devlink.c:59:21: note: in definition of macro ‘pr_out’
>    fprintf(stdout, ##args);   \
>                      ^~~~
> 
> Use uint64_t specific conversion specifiers in the format string to fix
> that.
> 
> Cc: Aya Levin <ayal@...lanox.com>
> Cc: Moshe Shemesh <moshe@...lanox.com>
> Signed-off-by: Baruch Siach <baruch@...s.co.il>

Both patches applied.