netdev - RE: [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR0501MB27693D777034422FC18A98B9C5F90@AM4PR0501MB2769.eurprd05.prod.outlook.com>
Date:   Mon, 1 Jul 2019 06:46:28 +0000
From:   Ran Rozenstein <ranro@...lanox.com>
To:     Tariq Toukan <tariqt@...lanox.com>,
        David Miller <davem@...emloft.net>,
        "fw@...len.de" <fw@...len.de>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Maor Gottlieb <maorg@...lanox.com>
Subject: RE: [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop



> -----Original Message-----
> From: Tariq Toukan
> Sent: Sunday, June 30, 2019 10:57
> To: David Miller <davem@...emloft.net>; fw@...len.de
> Cc: netdev@...r.kernel.org; Ran Rozenstein <ranro@...lanox.com>; Tariq
> Toukan <tariqt@...lanox.com>
> Subject: Re: [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop
> 
> 
> 
> On 6/27/2019 7:54 PM, David Miller wrote:
> > From: Florian Westphal <fw@...len.de>
> > Date: Thu, 27 Jun 2019 14:03:31 +0200
> >
> >> Tariq and Ran reported a regression caused by net-next commit
> >> 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list").
> >>
> >> This happens when net.ipv4.conf.$dev.promote_secondaries sysctl is
> >> enabled -- we can arrange for ifa->next to point at ifa, so next
> >> process that tries to walk the list loops forever.
> >>
> >> Fix this and extend rtnetlink.sh with a small test case for this.
> >
> > Series applied, thanks Florian.
> >
> 
> Thanks Florian!
> 
> Ran, please test and update.
> 
> Tariq

Thanks Florian.
Didn't reproduce tonight with the fixes.

Ran.