lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190702161133.GP30468@lunn.ch>
Date:   Tue, 2 Jul 2019 18:11:33 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sudarsana Reddy Kalluru <skalluru@...vell.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, mkalderon@...vell.com,
        aelior@...vell.com, jiri@...nulli.us
Subject: Re: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the
 port parameters.

On Tue, Jul 02, 2019 at 08:20:56AM -0700, Sudarsana Reddy Kalluru wrote:
> The patch adds devlink interfaces for drivers to publish/unpublish the
> devlink port parameters.

Hi Sudarsana

A good commit message says more about 'why' than 'what'. I can see the
'what' by reading the code. But the 'why' is often not so clear.

Why would i want to unpublish port parameters?

Thanks
	Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ