netdev - RE: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Jul 2019 16:18:03 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Sudarsana Reddy Kalluru <skalluru@...vell.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mkalderon@...vell.com" <mkalderon@...vell.com>,
        "aelior@...vell.com" <aelior@...vell.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>
Subject: RE: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the
 port parameters.



> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of Andrew Lunn
> Sent: Tuesday, July 2, 2019 9:42 PM
> To: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; mkalderon@...vell.com;
> aelior@...vell.com; jiri@...nulli.us
> Subject: Re: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the
> port parameters.
> 
> On Tue, Jul 02, 2019 at 08:20:56AM -0700, Sudarsana Reddy Kalluru wrote:
> > The patch adds devlink interfaces for drivers to publish/unpublish the
> > devlink port parameters.
> 
> Hi Sudarsana
> 
> A good commit message says more about 'why' than 'what'. I can see the
> 'what' by reading the code. But the 'why' is often not so clear.
> 
> Why would i want to unpublish port parameters?
> 
> Thanks
> 	Andrew

A vendor driver calling these APIs is needed at minimum.