netdev - Re: [PATCH 2/3 bpf-next] i40e: Support zero-copy XDP_TX on the RX path for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9c7b86c-91a6-9585-d1f1-f6f325794038@mellanox.com>
Date:   Tue, 2 Jul 2019 07:07:27 +0000
From:   Maxim Mikityanskiy <maximmi@...lanox.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bjorn.topel@...el.com" <bjorn.topel@...el.com>,
        "magnus.karlsson@...el.com" <magnus.karlsson@...el.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "kernel-team@...com" <kernel-team@...com>
Subject: Re: [PATCH 2/3 bpf-next] i40e: Support zero-copy XDP_TX on the RX
 path for AF_XDP sockets.

On 2019-06-29 01:15, Jonathan Lemon wrote:
> +	xdpf = convert_to_xdp_frame_keep_zc(xdp);
> +	if (unlikely(!xdpf))
> +		return I40E_XDP_CONSUMED;
> +	xdpf->handle = xdp->handle;

Shouldn't this line belong to convert_to_xdp_frame_keep_zc (and the 
previous patch)? It looks like it's code common for all drivers, and 
also patch 1 adds the handle field, but doesn't use it, which looks weird.