netdev - RE: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR18MB25280E0966EF3B8D9BEBF4F7D3FB0@MN2PR18MB2528.namprd18.prod.outlook.com>
Date:   Wed, 3 Jul 2019 02:46:35 +0000
From:   Sudarsana Reddy Kalluru <skalluru@...vell.com>
To:     Parav Pandit <parav@...lanox.com>, Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Michal Kalderon <mkalderon@...vell.com>,
        "Ariel Elior" <aelior@...vell.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>
Subject: RE: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the
 port parameters.


> -----Original Message-----
> From: Parav Pandit <parav@...lanox.com>
> Sent: Tuesday, July 2, 2019 10:49 PM
> To: Andrew Lunn <andrew@...n.ch>
> Cc: Sudarsana Reddy Kalluru <skalluru@...vell.com>;
> davem@...emloft.net; netdev@...r.kernel.org; Michal Kalderon
> <mkalderon@...vell.com>; Ariel Elior <aelior@...vell.com>;
> jiri@...nulli.us
> Subject: [EXT] RE: [PATCH net-next 1/1] devlink: Add APIs to
> publish/unpublish the port parameters.
> 
> External Email
> 
> ----------------------------------------------------------------------
> 
> 
> > -----Original Message-----
> > From: Andrew Lunn <andrew@...n.ch>
> > Sent: Tuesday, July 2, 2019 10:19 PM
> > To: Parav Pandit <parav@...lanox.com>
> > Cc: Sudarsana Reddy Kalluru <skalluru@...vell.com>;
> > davem@...emloft.net; netdev@...r.kernel.org;
> mkalderon@...vell.com;
> > aelior@...vell.com; jiri@...nulli.us
> > Subject: Re: [PATCH net-next 1/1] devlink: Add APIs to
> > publish/unpublish the port parameters.
> >
> > > A vendor driver calling these APIs is needed at minimum.
> >
> > Not a vendor driver, but a mainline driver.
> >
> My apologies for terminology.
> I meant to say that a NIC/hw driver from the kernel tree that created the
> devlink port should call this API (as user) in the patch.
> You said it rightly below. Thanks.
> 
> > But yes, a new API should not be added without at least one user.
> >
> >     Andrew
Thanks a lot for your reviews.
Marvell NIC driver has a requirement to support the display/configuration of device attributes. Sent the proposed changes with following 'subject line',
     [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.
Have received a comment (from community) suggesting to move some of the attributes to devlink-port interface, which
requires the proposed APIs.

Will update the commit message and send it with the Marvel driver patch series which use this functionality.