netdev - Re: [PATCH bpf-next v2 0/8] bpf: TCP RTT sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0E380C87-29CC-4F4C-869B-22C1A18F9B35@fb.com>
Date:   Wed, 3 Jul 2019 03:04:31 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Y Song <ys114321@...il.com>, Stanislav Fomichev <sdf@...gle.com>
CC:     netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Priyaranjan Jha <priyarjha@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        "Soheil Hassas Yeganeh" <soheil@...gle.com>
Subject: Re: [PATCH bpf-next v2 0/8] bpf: TCP RTT sock_ops bpf callback


On 7/2/19, 10:55 AM, "netdev-owner@...r.kernel.org on behalf of Y Song" <netdev-owner@...r.kernel.org on behalf of ys114321@...il.com> wrote:

    On Tue, Jul 2, 2019 at 9:14 AM Stanislav Fomichev <sdf@...gle.com> wrote:
    >
    > Congestion control team would like to have a periodic callback to
    > track some TCP statistics. Let's add a sock_ops callback that can be
    > selectively enabled on a socket by socket basis and is executed for
    > every RTT. BPF program frequency can be further controlled by calling
    > bpf_ktime_get_ns and bailing out early.
    >
    > I run neper tcp_stream and tcp_rr tests with the sample program
    > from the last patch and didn't observe any noticeable performance
    > difference.
    >
    > v2:
    > * add a comment about second accept() in selftest (Yonghong Song)
    > * refer to tcp_bpf.readme in sample program (Yonghong Song)
    >
    > Suggested-by: Eric Dumazet <edumazet@...gle.com>
    > Cc: Eric Dumazet <edumazet@...gle.com>
    > Cc: Priyaranjan Jha <priyarjha@...gle.com>
    > Cc: Yuchung Cheng <ycheng@...gle.com>
    > Cc: Soheil Hassas Yeganeh <soheil@...gle.com>
    > Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
    > Acked-by: Yuchung Cheng <ycheng@...gle.com>
    
    Ack for the whole series.
    Acked-by: Yonghong Song <yhs@...com>

Thanks, this is a very nice feature!
    
Ack for the whole series.
Acked-by: Lawrence Brakmo <brakmo@...com>

    >
    > Stanislav Fomichev (8):
    >   bpf: add BPF_CGROUP_SOCK_OPS callback that is executed on every RTT
    >   bpf: split shared bpf_tcp_sock and bpf_sock_ops implementation
    >   bpf: add dsack_dups/delivered{,_ce} to bpf_tcp_sock
    >   bpf: add icsk_retransmits to bpf_tcp_sock
    >   bpf/tools: sync bpf.h
    >   selftests/bpf: test BPF_SOCK_OPS_RTT_CB
    >   samples/bpf: add sample program that periodically dumps TCP stats
    >   samples/bpf: fix tcp_bpf.readme detach command
    >
    >  include/net/tcp.h                           |   8 +
    >  include/uapi/linux/bpf.h                    |  12 +-
    >  net/core/filter.c                           | 207 +++++++++++-----
    >  net/ipv4/tcp_input.c                        |   4 +
    >  samples/bpf/Makefile                        |   1 +
    >  samples/bpf/tcp_bpf.readme                  |   2 +-
    >  samples/bpf/tcp_dumpstats_kern.c            |  68 ++++++
    >  tools/include/uapi/linux/bpf.h              |  12 +-
    >  tools/testing/selftests/bpf/Makefile        |   3 +-
    >  tools/testing/selftests/bpf/progs/tcp_rtt.c |  61 +++++
    >  tools/testing/selftests/bpf/test_tcp_rtt.c  | 254 ++++++++++++++++++++
    >  11 files changed, 574 insertions(+), 58 deletions(-)
    >  create mode 100644 samples/bpf/tcp_dumpstats_kern.c
    >  create mode 100644 tools/testing/selftests/bpf/progs/tcp_rtt.c
    >  create mode 100644 tools/testing/selftests/bpf/test_tcp_rtt.c
    >
    > --
    > 2.22.0.410.gd8fdbe21b5-goog