netdev - Re: [rdma 1/1] RDMA/irdma: Add Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190704121826.GC3401@mellanox.com>
Date:   Thu, 4 Jul 2019 12:18:29 +0000
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:     "dledford@...hat.com" <dledford@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "poswald@...e.com" <poswald@...e.com>,
        "david.m.ertman@...el.com" <david.m.ertman@...el.com>,
        "mustafa.ismail@...el.com" <mustafa.ismail@...el.com>
Subject: Re: [rdma 1/1] RDMA/irdma: Add Kconfig and Makefile

On Wed, Jul 03, 2019 at 07:12:43PM -0700, Jeff Kirsher wrote:
> From: Shiraz Saleem <shiraz.saleem@...el.com>
> 
> Add Kconfig and Makefile to build irdma driver and mark i40iw
> deprecated/obsolete, since the irdma driver is replacing it and supports
> x722 devices.

Patch 1/1? Series looks mangled...

> diff --git a/drivers/infiniband/hw/i40iw/Kconfig b/drivers/infiniband/hw/i40iw/Kconfig
> index d867ef1ac72a..7454b84b74be 100644
> +++ b/drivers/infiniband/hw/i40iw/Kconfig
> @@ -1,8 +1,10 @@
>  config INFINIBAND_I40IW
> -	tristate "Intel(R) Ethernet X722 iWARP Driver"
> +	tristate "Intel(R) Ethernet X722 iWARP Driver (DEPRECATED)"
>  	depends on INET && I40E
>  	depends on IPV6 || !IPV6
>  	depends on PCI
> +	depends on !(INFINBAND_IRDMA=y || INFINIBAND_IRDMA=m)

No.. all drivers must be able to build at once. At least add some
COMPILE_TEST in here to enable building.

Jason