netdev - Re: [PATCH] selftests: txring_overwrite: fix incorrect test of mmap() return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSfYC_gP3ACV7E0M-i8zVXbmnrfu_+AE4j4QrVDTDPJscg@mail.gmail.com>
Date:   Fri, 5 Jul 2019 15:55:56 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Frank de Brabander <debrabander@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] selftests: txring_overwrite: fix incorrect test of mmap()
 return value

On Fri, Jul 5, 2019 at 7:44 AM Frank de Brabander <debrabander@...il.com> wrote:
>
> If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1).
> The current if-statement incorrectly tests if *ring is NULL.
>
> Signed-off-by: Frank de Brabander <debrabander@...il.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Fixes: 358be656406d ("selftests/net: add txring_overwrite")

Thanks Frank. Please mark future networking patches as [PATCH net] or
[PATCH net-next].