netdev - Re: [PATCH] selftests: txring_overwrite: fix incorrect test of mmap() return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190708.154034.2114427019293786374.davem@davemloft.net>
Date:   Mon, 08 Jul 2019 15:40:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     debrabander@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] selftests: txring_overwrite: fix incorrect test of
 mmap() return value

From: Frank de Brabander <debrabander@...il.com>
Date: Fri,  5 Jul 2019 13:43:14 +0200

> If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1).
> The current if-statement incorrectly tests if *ring is NULL.
> 
> Signed-off-by: Frank de Brabander <debrabander@...il.com>

Applied with fixes tag added and queued up for -stable, thanks.