lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Jul 2019 15:42:13 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Pablo Neira Ayuso <pablo@...filter.org> Cc: netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, davem@...emloft.net, thomas.lendacky@....com, f.fainelli@...il.com, ariel.elior@...ium.com, michael.chan@...adcom.com, madalin.bucur@....com, yisen.zhuang@...wei.com, salil.mehta@...wei.com, jeffrey.t.kirsher@...el.com, tariqt@...lanox.com, saeedm@...lanox.com, jiri@...lanox.com, idosch@...lanox.com, peppe.cavallaro@...com, grygorii.strashko@...com, andrew@...n.ch, vivien.didelot@...il.com, alexandre.torgue@...com, joabreu@...opsys.com, linux-net-drivers@...arflare.com, ogerlitz@...lanox.com, Manish.Chopra@...ium.com, marcelo.leitner@...il.com, mkubecek@...e.cz, venkatkumar.duvvuru@...adcom.com, maxime.chevallier@...tlin.com, cphealy@...il.com Subject: Re: [PATCH 12/15 net-next,v2] net: flow_offload: make flow block callback list per-driver On Fri, 5 Jul 2019 01:48:40 +0200, Pablo Neira Ayuso wrote: > diff --git a/drivers/net/ethernet/netronome/nfp/abm/cls.c b/drivers/net/ethernet/netronome/nfp/abm/cls.c > index 96b89a7c468b..a42f92318b7a 100644 > --- a/drivers/net/ethernet/netronome/nfp/abm/cls.c > +++ b/drivers/net/ethernet/netronome/nfp/abm/cls.c > @@ -262,9 +262,12 @@ static int nfp_abm_setup_tc_block_cb(enum tc_setup_type type, > } > } > > +static LIST_HEAD(nfp_abm_vf_block_cb_list); s/_vf// > int nfp_abm_setup_cls_block(struct net_device *netdev, struct nfp_repr *repr, > struct flow_block_offload *f) > { > - return flow_block_setup_offload(f, nfp_abm_setup_tc_block_cb, > + return flow_block_setup_offload(f, &nfp_abm_block_cb_list, > + nfp_abm_setup_tc_block_cb, > repr, repr, true); > } > diff --git a/drivers/net/ethernet/netronome/nfp/bpf/main.c b/drivers/net/ethernet/netronome/nfp/bpf/main.c > index 3897cc4f7a7e..5316d85261c0 100644 > --- a/drivers/net/ethernet/netronome/nfp/bpf/main.c > +++ b/drivers/net/ethernet/netronome/nfp/bpf/main.c > @@ -160,6 +160,8 @@ static int nfp_bpf_setup_tc_block_cb(enum tc_setup_type type, > return 0; > } > > +static LIST_HEAD(nfp_bfp_block_cb_list); s/bfp/bpf/ > static int nfp_bpf_setup_tc(struct nfp_app *app, struct net_device *netdev, > enum tc_setup_type type, void *type_data) > { > @@ -168,6 +170,7 @@ static int nfp_bpf_setup_tc(struct nfp_app *app, struct net_device *netdev, > switch (type) { > case TC_SETUP_BLOCK: > return flow_block_setup_offload(type_data, > + &nfp_bfp_block_cb_list, > nfp_bpf_setup_tc_block_cb, > nn, nn, true); > default:
Powered by blists - more mailing lists