netdev - RE: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for configuration attributes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 5 Jul 2019 08:22:41 +0000
From:   Sudarsana Reddy Kalluru <skalluru@...vell.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Michal Kalderon <mkalderon@...vell.com>,
        "Ariel Elior" <aelior@...vell.com>, Jiri Pirko <jiri@...nulli.us>
Subject: RE: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for
 configuration attributes.

> -----Original Message-----
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Sent: Friday, July 5, 2019 3:38 AM
> To: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Michal Kalderon
> <mkalderon@...vell.com>; Ariel Elior <aelior@...vell.com>; Jiri Pirko
> <jiri@...nulli.us>
> Subject: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for
> configuration attributes.
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, 4 Jul 2019 06:20:11 -0700, Sudarsana Reddy Kalluru wrote:
> > This patch adds implementation for devlink callbacks for reading and
> > configuring the device attributes.
> >
> > Signed-off-by: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> > Signed-off-by: Ariel Elior <aelior@...vell.com>
> > ---
> >  Documentation/networking/devlink-params-qede.txt |  72 ++++++++
> >  drivers/net/ethernet/qlogic/qed/qed_main.c       |  38 +++++
> >  drivers/net/ethernet/qlogic/qede/qede.h          |   3 +
> >  drivers/net/ethernet/qlogic/qede/qede_devlink.c  | 202
> > ++++++++++++++++++++++-
> drivers/net/ethernet/qlogic/qede/qede_devlink.h  |  23 +++
> >  include/linux/qed/qed_if.h                       |  16 ++
> >  6 files changed, 353 insertions(+), 1 deletion(-)  create mode 100644
> > Documentation/networking/devlink-params-qede.txt
> >
> > diff --git a/Documentation/networking/devlink-params-qede.txt
> > b/Documentation/networking/devlink-params-qede.txt
> > new file mode 100644
> > index 0000000..f78a993
> > --- /dev/null
> > +++ b/Documentation/networking/devlink-params-qede.txt
> > @@ -0,0 +1,72 @@
> > +enable_sriov		[DEVICE, GENERIC]
> > +			Configuration mode: Permanent
> > +
> > +iwarp_cmt		[DEVICE, DRIVER-SPECIFIC]
> > +			Enable iWARP support over 100G device (CMT
> mode).
> > +			Type: Boolean
> > +			Configuration mode: runtime
> > +
> > +entity_id		[DEVICE, DRIVER-SPECIFIC]
> > +			Set the entity ID value to be used for this device
> > +			while reading/configuring the devlink attributes.
> > +			Type: u8
> > +			Configuration mode: runtime
> 
> Can you explain what this is?
Hardware/mfw provides the option to modify/read the config of other PFs. A non-zero entity id represents a partition number (or simply a PF-id) for which the config need to be read/updated.

> 
> > +device_capabilities	[DEVICE, DRIVER-SPECIFIC]
> > +			Set the entity ID value to be used for this device
> > +			while reading/configuring the devlink attributes.
> > +			Type: u8
> > +			Configuration mode: runtime
> 
> Looks like you copied the previous text here.
Will update it, thanks.

> 
> > +mf_mode			[DEVICE, DRIVER-SPECIFIC]
> > +			Configure Multi Function mode for the device.
> > +			Supported MF modes and the assoicated values are,
> > +			    MF allowed(0), Default(1), SPIO4(2), NPAR1.0(3),
> > +			    NPAR1.5(4), NPAR2.0(5), BD(6) and UFP(7)
> 
> NPAR should have a proper API in devlink port, what are the other modes?
> 
These are the different modes supported by the Marvell NIC. In our case the mf_mode is per adapter basis, e.g., it's not possible to configure one port in NPAR mode and the other in Default mode.

> > +			Type: u8
> > +			Configuration mode: Permanent
> > +
> > +dcbx_mode		[PORT, DRIVER-SPECIFIC]
> > +			Configure DCBX mode for the device.
> > +			Supported dcbx modes are,
> > +			    Disabled(0), IEEE(1), CEE(2) and Dynamic(3)
> > +			Type: u8
> > +			Configuration mode: Permanent
> 
> Why is this a permanent parameter?
> 
This specifies the dcbx_mode to be configured in non-volatile memory. The value is persistent and is used in the next load of OS or the mfw.

> > +preboot_oprom		[PORT, DRIVER-SPECIFIC]
> > +			Enable Preboot Option ROM.
> > +			Type: Boolean
> > +			Configuration mode: Permanent
> 
> This should definitely not be a driver specific toggle.
> 
> > +preboot_boot_protocol	[PORT, DRIVER-SPECIFIC]
> > +			Configure preboot Boot protocol.
> > +			Possible values are,
> > +			    PXE(0), iSCSI Boot(3), FCoE Boot(4) and NONE(7)
> > +			Type: u8
> > +			Configuration mode: Permanent
> 
> Ditto.
> 
> > +preboot_vlan		[PORT, DRIVER-SPECIFIC]
> > +			Preboot VLAN.
> > +			Type: u16
> > +			Configuration mode: Permanent
> > +
> > +preboot_vlan_value	[PORT, DRIVER-SPECIFIC]
> > +			Configure Preboot VLAN value.
> > +			Type: u16
> > +			Configuration mode: Permanent
> 
> And these.
Sure, will add generic definitions for these.

> 
> > +mba_delay_time		[PORT, DRIVER-SPECIFIC]
> > +			Configure MBA Delay Time. Supported range is [0-
> 15].
> > +			Type: u8
> > +			Configuration mode: Permanent
> > +
> > +mba_setup_hot_key	[PORT, DRIVER-SPECIFIC]
> > +			Configure MBA setup Hot Key. Possible values are,
> > +			Ctrl S(0) and Ctrl B(1).
> > +			Type: u8
> > +			Configuration mode: Permanent
> > +
> > +mba_hide_setup_prompt	[PORT, DRIVER-SPECIFIC]
> > +			Configure MBA hide setup prompt.
> > +			Type: Boolean
> > +			Configuration mode: Permanent