netdev - Re: [PATCH] coallocate socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190708.192558.1304552003355538760.davem@davemloft.net>
Date:   Mon, 08 Jul 2019 19:25:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     viro@...iv.linux.org.uk
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] coallocate socket_wq with socket itself

From: Al Viro <viro@...iv.linux.org.uk>
Date: Fri, 5 Jul 2019 20:14:16 +0100

> socket->wq is assign-once, set when we are initializing both
> struct socket it's in and struct socket_wq it points to.  As the
> matter of fact, the only reason for separate allocation was the
> ability to RCU-delay freeing of socket_wq.  RCU-delaying the
> freeing of socket itself gets rid of that need, so we can just
> fold struct socket_wq into the end of struct socket and simplify
> the life both for sock_alloc_inode() (one allocation instead of
> two) and for tun/tap oddballs, where we used to embed struct socket
> and struct socket_wq into the same structure (now - embedding just
> the struct socket).
> 
> Note that reference to struct socket_wq in struct sock does remain
> a reference - that's unchanged.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Applied.