netdev - Re: [PATCH net-next v6 0/4] net/sched: Introduce tc connection tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190709.121402.1804664264408465946.davem@davemloft.net>
Date:   Tue, 09 Jul 2019 12:14:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     jiri@...lanox.com, roid@...lanox.com, yossiku@...lanox.com,
        ozsh@...lanox.com, marcelo.leitner@...il.com,
        netdev@...r.kernel.org, aconole@...hat.com, wangzhike@...com,
        ronye@...lanox.com, nst-kernel@...hat.com,
        john.hurley@...ronome.com, simon.horman@...ronome.com,
        jpettit@....org
Subject: Re: [PATCH net-next v6 0/4] net/sched: Introduce tc connection
 tracking

From: Paul Blakey <paulb@...lanox.com>
Date: Tue,  9 Jul 2019 10:30:47 +0300

> This patch series add connection tracking capabilities in tc sw datapath.
> It does so via a new tc action, called act_ct, and new tc flower classifier matching
> on conntrack state, mark and label.
 ...

Ok, I applied this, but two things:

1) You owe Cong Wang an explanation, a real detailed one, about the L2
   vs L3 design of this feature.  I did not see you address his feedback,
   but if you did I apologize.

2) Because the MPLS changes went in first, TCA_ID_CT ended up in a
   different spot in the enumeration and therefore the value is
   different.

Thanks.